Skip to content

Provide ability to get model configs with a model id #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Jun 5, 2024

Description

  • I noticed there is no way to get model config ids from the UI or easily from SDK without attaching it to a project. So I made a method to get model configs for Live model evaluation projects based on a model id you can get from the UI.

  • This allows the flexibility to quickly add them to projects or just manage them in general, which is not even available on the UI yet.

Loom to explain issue:
https://www.loom.com/share/d086b0f8b4e5456c97a5077cf395f1b3?sid=e0ac0a7a-a48f-42fa-9725-0ef268a65d5f

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

@Gabefire Gabefire requested a review from a team as a code owner June 5, 2024 21:17
@Gabefire Gabefire changed the title added get_model_configs methods Provide ability to get model configs with a model id Jun 5, 2024
@Gabefire
Copy link
Collaborator Author

Gabefire commented Jun 5, 2024

Quick question: What org do tests inside Labelbox-python sdk run against? Is it just the default stageing org or an SDK-specific one? I ask because for this method, I'm trying to test, and I don't think we are cleaning the model configs between other tests. It should be assert two for the valid model ID given, but it has 297 model configs attached. Tests work against my prod org. basically, I attached some model configs and then tested if it returns two model configs. If you don't mind could I make the model id fixture delete all the model configs attached to a model when it tears down?

@Gabefire Gabefire added the enhancement New feature or request label Jun 5, 2024
@Gabefire Gabefire closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant